Implement chart authoring feedback from issue #9 - #15
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 259 files, which is 159 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (259)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whenFocusedmarks, with shared primary/group/source/pinned state across SVG, Canvas, custom surfaces, tooltips, and exportstateswith single object-bag callbacks, ordered style overrides, and SVG/Canvas transitions for changing existing geometrycolor, support explicitstack({ order, offset }), and makelayout: group()the side-by-side opt-inBreaking changes
Axis presentation now lives under
x.axisandy.axis. Existingguide,ticks,format,label,tickRotate, andlabelOffsetfields migrate to the nested axis model.gridremains at the scale layer and is independent from axis visibility.Repeated bars now stack by default. Use
layout: group()for side-by-side bars andlayout: stack(...)only when overriding stack order or offset. A categoricalcolorchannel supplies series identity whenzis absent; continuous color requires explicitz.General transforms are pure eager functions, not a mark-options protocol or reactive graph. There is no
transformDataAPI; custom and composed transforms are ordinary functions that can live outside chart code.Bundle audit
d3-array, row stacks may retaind3-shape, and other granular families reject both plus unrelated transformsValidation
pnpm test: 120 files / 629 testspnpm typecheckpnpm docs:check: 82 pages, 84 catalog embeds, 17 executable examplespnpm package:check: packed exports/runtime plus seven framework adapterspnpm bundle:check: all exact baselines, feature ceilings, and module boundaries passpnpm benchmark:check: all 60 comparison bundles pass against committed-source provenancepnpm format:checkCloses #9